Add and tweak barcode tests #4700
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's used in filters, so put it in that context
sampart
commented
Oct 2, 2024
| @@ -58,17 +58,29 @@ | |||
| it "->barcodeable_id shows only barcodes for a specific barcodeable_id" do | |||
| global_barcode_item | |||
| create(:global_barcode_item, base_item: create(:base_item)) | |||
| results = BarcodeItem.barcodeable_id(base_item.id) | |||
| items = BarcodeItem.barcodeable_id(base_item.id) | |||
There was a problem hiding this comment.
This felt more descriptive, and matches what we used in our new/altered tests below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3554
Description
#3554 is about addressing
TODOcomments. There were several inspec/models/barcode_item_spec.rbabout adding tests.describes(and their TODO comments) and added a comment pointing readers to that contextby_item_partner_keybut since it's also used in filtering, we put it in that context tooby_base_item_partner_keymore robust by adding a test on the number of returned itemsdescribed "global"didn't match behaviour, so we updated that.Paired with @mgriffin ❤️
Type of change
How Has This Been Tested?
CI