tmp: accept frozen strings #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: ruby/ruby#10235 As discussed upstream, the mutability is only used in one spec, `path.rb`: ```ruby @name = +"file_to_path" @path = tmp(@name) ``` For all the others it doesn't matter if the argument is mutated or not.
casperisfine
force-pushed
the
tmp-frozen-string
branch
from
2b17e42
to
101de07
Compare
eregon
reviewed
Mar 13, 2024
| @@ -41,6 +41,7 @@ def tmp(name, uniquify = true) | |||
| if uniquify and !name.empty? | |||
| slash = name.rindex "/" | |||
| index = slash ? slash + 1 : 0 | |||
| name = +name | |||
There was a problem hiding this comment.
I think .dup might be nicer here, because then this method simply never mutates the argument, which feels cleaner, could you switch to that?
There was a problem hiding this comment.
Ah I see + is more compatible and in fact current ruby/spec passes with this change.
Let's merge as-is then and maybe clean this up later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ruby/ruby#10235
As discussed upstream, the mutability is only used in one spec,
path.rb:For all the others it doesn't matter if the argument is mutated or not.
cc @eregon