Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rails reloading instructions in README #1767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yeonhoyoon
Copy link

Rails reloading insturctions no longer required as of Rails >= 5.2

Rails reloading insturctions no longer required as of Rails >= 5.2
@grape-bot
Copy link

grape-bot commented Jun 15, 2018

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#1767](https://github.com/ruby-grape/grape/pull/1767): Update rails reloading instructions in readme - [@yeonhoyoon](https://github.com/yeonhoyoon).

Generated by 🚫 danger

Modify `application.rb`:

```ruby
config.paths.add File.join('app', 'api'), glob: File.join('**', '*.rb')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we should leave this for older versions? Maybe just make sections

#### Rails 5.2 or Newer
...

#### Rails 4.0

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants