Add fonts for new builtin Shiny theme preset #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
commented
Jun 16, 2023
| @@ -0,0 +1,31 @@ | |||
| /*-- scss:rules --*/ | |||
| $web-font-path: "https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300;0,400;0,500;0,600;0,700;0,800;1,300;1,400;1,500;1,600;1,700;1,800&family=Source+Code+Pro:ital,wght@0,400;0,600;1,400;1,600&display=swap" !default; | |||
There was a problem hiding this comment.
@gregswinehart Do you think we could cut back these font weights a little bit?
There was a problem hiding this comment.
I suppose we could if it's a thing. That said, I would probably only lose the 800 weight? I like to celebrate the whole catalog....
There was a problem hiding this comment.
Thanks Greg. I'm going to leave this as is for now and will review again with Carson this week.
schloerke
reviewed
Jun 16, 2023
schloerke
reviewed
Jun 16, 2023
schloerke
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #630 and adds the desired font stack for the new Shiny theme, namely Open Sans and Source Code Pro.
This PR updates the
tools/download_bootswatch_fonts.Rscript to also download fonts for builtin presets. This necessitated a few changes:tools/download_bootswatch_fonts.Ris nowtools/download_preset_fonts.R_bootswatch.scssor_rules.scssfiles (in that order)inst/bs{version}/{name}/_variables.scssand_rules.scss.From what I can tell, these new fonts add ~600KB to the package bundle. We may want to cut back on font weights or figure out how to reduce the package bundle size, but I'm also okay waiting for on that for another PR.