Skip to content

Commit

Permalink
fix(preset-shiny): Fix border of radio and checkbox buttons (#1038)
Browse files Browse the repository at this point in the history
* fix(preset-shiny): Fix border of radio and checkbox buttons

* refactor: form-check now uses `$input-border-color`

* docs: add news item
  • Loading branch information
gadenbuie committed Apr 10, 2024
1 parent 2e6b202 commit 2c87d0c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# bslib (development version)

* Adjusted the border color of checkbox and radio buttons to match the border color of the input group in `bs_theme(preset="shiny")` . (#1038)

# bslib 0.7.0

This large release includes many improvements and bug fixes for newer UI components like `layout_columns()`, `card()`, and `sidebar()`. In addition, the new `input_task_button()` offers a drop-in replacement for `shiny::actionButton()` (to prevent multiple submissions of the same operation) as well as pairing nicely with the new `shiny::ExtendedTask` for implementing truly non-blocking operations in Shiny.
Expand Down
Binary file modified R/sysdata.rda
Binary file not shown.
5 changes: 4 additions & 1 deletion inst/builtin/bs5/shiny/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ $gradient: linear-gradient(
$body-color: $gray-900 !default;
$body-bg: $white !default;

$prefix: bs- !default;

// Fonts
$font-family-base: "Open Sans", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif !default;
$font-family-monospace: "Source Code Pro", SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace !default;
Expand Down Expand Up @@ -88,6 +90,7 @@ $form-text-color: $gray-600 !default;
// Borders
$input-border-color: $gray-500 !default;
$border-radius: 3px !default;
$form-check-input-border: var(--#{$prefix}border-width) solid $input-border-color !default;
// Defaults to $gray700, of which we've set to a blueish-gray, which looks a bit weird...
// We could go forward with the blue-ish gray, but if we do, we'll want to also make
// $border-color-translucent-dark a bit more blueish
Expand Down Expand Up @@ -132,7 +135,7 @@ $card-border-radius: 8px !default;
// * white navbar and title panel

$bslib-dashboard-design: true !default;
$bslib-enable-shadows: $bslib-dashboard-design !default
$bslib-enable-shadows: $bslib-dashboard-design !default;

$border-color-translucent: if($bslib-dashboard-design, rgba(40, 70, 94, 0.1), null) !default;
$border-color-translucent-dark: if($bslib-dashboard-design, rgba(255, 255, 255, 0.1), null) !default;
Expand Down
2 changes: 1 addition & 1 deletion inst/css-precompiled/5/bootstrap.min.css

Large diffs are not rendered by default.

0 comments on commit 2c87d0c

Please sign in to comment.