Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not handling skip creation part in case of api key not defined for a stage #47

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sromic
Copy link

@sromic sromic commented Aug 20, 2021

Default an apiKey array to an empty array in case of api keys not defined for a stage.

removeded not needed return statement
@rrahul963
Copy link
Owner

@sromic - can you please update the version in package.json so that this can be merged

@sromic
Copy link
Author

sromic commented Sep 5, 2022

@sromic - can you please update the version in package.json so that this can be merged

@rrahul963 sorry, I missed this :S.
I've merged from your master, so it should be up to date with all new changes.

@sromic
Copy link
Author

sromic commented Jul 31, 2023

@rrahul963 any plans to have this PR merged?

@rrahul963
Copy link
Owner

@sromic - can you update the version on package.json file and run the builds

@sromic
Copy link
Author

sromic commented Jul 31, 2023

@rrahul963 done. Please review and merge is looks good. Ty!

@sromic
Copy link
Author

sromic commented Apr 11, 2024

@rrahul963 any plans to merge this PR? It's been sitting for a while now :)

@cvargas-xbrein
Copy link

cvargas-xbrein commented Apr 11, 2024

mm maby , same issue when run sls remove ?, error in line 407 TypeError: apiKeys is not iterable

@sromic
Copy link
Author

sromic commented Apr 12, 2024

mm maby , same issue when run sls remove ?, error in line 407 TypeError: apiKeys is not iterable

could be, let me revisit that as well, ty!

@sromic
Copy link
Author

sromic commented Apr 12, 2024

@cvargas-xbrein , @rrahul963 ty, added this for remove hook as well.

@sromic
Copy link
Author

sromic commented Apr 16, 2024

Hi @cvargas-xbrein, @rrahul963 I would appreciate a review to this PR. Ty!

@sromic
Copy link
Author

sromic commented May 21, 2024

Hi @cvargas-xbrein , @rrahul963 any news on getting this reviewed and potentially merged? Ty in advance!

@sromic
Copy link
Author

sromic commented Jul 3, 2024

@rrahul963 sorry for bothering, any plans to have this reviewed and merged in? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants