Unconditionally add -Wformat-security GCC/Clang option, remove GCC_FO…

…RMAT_SECURITY macro (#191) * Unconditionally add -Wformat-security GCC/Clang option, remove GCC_FORMAT_SECURITY macro * Updated ChangeLog
royhills · Aug 26, 2024 · 89ae57e · 89ae57e
1 parent 74735d5
commit 89ae57e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 31 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -6,8 +6,14 @@
 	  by Clang. There are no supported systems with earlier GCC versions.
 	  https://github.com/royhills/arp-scan/pull/190
 
+	* configure.ac: Unconditionally add -Wformat-security to GCC/Clang
+	  compiler options instead of using the GCC_FORMAT_SECURITY macro.
+	  https://github.com/royhills/arp-scan/pull/191
+
 	* m4/gcc-wextra.m4: Removed.
 
+	* m4/gcc-format-security.m4: Removed.
+
 2024-08-14 Roy Hills <royhills@hotmail.com>
 
 	* get-iab: removed. This script is no longer needed and was depreciated

diff --git a/configure.ac b/configure.ac
@@ -41,10 +41,9 @@ fi
 if test -n "$GCC"; then
    AC_DEFINE([ATTRIBUTE_UNUSED], [__attribute__ ((__unused__))],
              [Define to the compiler's unused pragma])
-   CFLAGS="$CFLAGS -Wall -Wextra -Wshadow -Wwrite-strings"
+   CFLAGS="$CFLAGS -Wall -Wextra -Wformat-security -Wshadow -Wwrite-strings"
    GCC_STACK_PROTECT_CC
    GCC_FORTIFY_SOURCE
-   GCC_FORMAT_SECURITY
 # Uncomment the line below to compile with additional warnings enabled.
 # CFLAGS="$CFLAGS -pedantic -Wpointer-arith -Wcast-qual -Wcast-align -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs"
 else

diff --git a/m4/gcc-format-security.m4 b/m4/gcc-format-security.m4