Fix handling of duplicate dependencies #902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rest of the code implicitly assumes no duplicates in the deps list and fails in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates in resolved dependencies are uncommon, but one such case is
ffmpegandlibswscale-dev, where both depend on thelibswscale-devapt package. Trying to install them simultaneously fails withThis appears to be caused by
debian._read_apt_cache_showpkg()assuming a roughly one-to-one correspondence between thepackagesinput list and the output lines fromapt-cache showpkg. Due to the latter ignoring any duplicates, the resulting list of dependencies to be installed gets corrupted and some of them will fail to be installed.As a fix, this PR removes any duplicates in the list of resolved dependencies (without affecting the order).