Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include debug logging in Robot log.html #148

Conversation

JFoederer
Copy link
Contributor

While using robotkernel I was missing the debug logging from my underlying libraries. With this PR debug logging is included in the log.html files, but hidden by default. It can be revealed by selecting debug from the pull-down menu in the upper-right corner.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

lite-badge 👈 Try it on ReadTheDocs

@datakurre datakurre merged commit 57cdbc3 into robots-from-jupyter:master Aug 2, 2023
7 checks passed
@datakurre
Copy link
Collaborator

@JFoederer Thanks for contributing this. I was made aware that this is missing, but have been thinking something way too complex to configure it "Jupyter way". It's probably good to include debug log by default now and if there is ever need to suppress log, do it then.

This will increase saved notebook sizes (logs are included when executed notebooks are saved and shared), but probably it is not a real problem.

@JFoederer
Copy link
Contributor Author

Thank you for accepting the PR @datakurre. You are right about the increase in size, but that shouldn't be an issue. If people are really bothered by that, they can change the loglevel in the logging module. Then it is already filtered out before it gets to the Robot logs. If no debug lines are present in the log, the pulldown menu is not shown, so you are back in the old situation.

@JFoederer JFoederer deleted the include-and-filter-debug-logging branch August 2, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants