Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacig simm und uimm with offset #41

Conversation

christian-herber-nxp
Copy link
Collaborator

Issue stated to replace simm. I suspect we also want to replace uimm with offset.
Similar to other issues, this notion was taken from Zcb.
It may make sense to update there as well.

@christian-herber-nxp christian-herber-nxp linked an issue Jul 3, 2024 that may be closed by this pull request
@tovine
Copy link
Collaborator

tovine commented Jul 3, 2024

Aren't we missing information here (or making it less obvious) by removing the u and s variants in favor of just offset?
From an implementor's perspective it's immediately clear how the immediate bits need to be extended like it was written before, but when it just says offset then it takes more than just a quick glance at the encoding table to see what it should be.

I respect if this is the ARC's position on the matter, just wanted to raise the question.

EDIT: I see it's just in the mnemonic, and agree that it doesn't really matter that much there plus it looks better this way.

@christian-herber-nxp christian-herber-nxp merged commit 411a45d into main Jul 4, 2024
1 check passed
@christian-herber-nxp christian-herber-nxp deleted the 33-using-offset-in-the-mnemonic-is-preferred-than-simm branch July 4, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using offset in the mnemonic is preferred than simm
3 participants