Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial pre-commit and fix up and issues #10

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

kbroch-rivosinc
Copy link
Contributor

relates to #9

Copy link
Collaborator

@rpsene rpsene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wmat wmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kevin.

@kbroch-rivosinc
Copy link
Contributor Author

Sorry about the forced pushing above, I didn't change anything but had forgot to do the git commit -S and at first I thought I only needed git commit -s which is why there's multiple forced push. I'll try not to make a mess of things next time 😉

@wmat
Copy link
Collaborator

wmat commented Apr 24, 2024 via email

relates to #8 and #9

Signed-off-by: Kevin Broch <kbroch@rivosinc.com>
@kbroch-rivosinc kbroch-rivosinc self-assigned this Apr 24, 2024
@kbroch-rivosinc kbroch-rivosinc merged commit d512b61 into main Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants