Initial covergroups for Zvk* instructions #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
This patch introduces initial versions of covergroups for the Zvk* instructions. The lack of vector support makes these pretty useless, but once this is available it should not be too hard to adjust these. Support for RV32 and RV64 is added, but both versions are identical. Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
13 tasks
Signed-off-by: Umer Shahid <umer.shahid@10xengineers.ai>
Updated ChangeLOG file and resolved conflicts Signed-off-by: Umer Shahid <umer.shahid@10xengineers.ai>
|
Since it was a very old PR, I have resolved its conflicts |
Merged version number to resolve the conflict with __init__.py Signed-off-by: Umer Shahid <umer.shahid@10xengineers.ai>
UmerShahidengr
previously approved these changes
May 3, 2024
|
There are no red flags in the review, we can merge it but it won't be useful for us as vector tests cant be generated through ctg so there is no point in keeping vector registers in here. |
|
These coverpoints are incomplete and also outside the scope of this repo as vector tests will not be generated through ctg. I am closing this one to clear the backlog. |
|
We are letting this one and riscv-arch-tests (PR#33) go into the dev as riscv-arch-tests is the right platform where vector/crypto tests will be collected eventually. |
UmerShahidengr
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces initial versions of covergroups for the Zvk* instructions.
The lack of vector support makes these pretty useless, but once this is available it should not be too hard to adjust these.
Support for RV32 and RV64 is added, but both versions are identical.