ansible 2.16: add docker dependency #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although good to mention, this makes the docker mandatory for everyone, while this might not be the case, hence the empty array. You could just add a note and # note/mention the optional dependency? |
Stunkymonkey
force-pushed
the
ansible-2.16-add-docker-dependency
branch
from
abf42cd
to
d575e37
Compare
|
yes you are right. it is more an optional one. marked it as comment. or do you want this to be in the README? |
|
Both options are fine, if it’s there to assist people in making a correct choice, then it’s good right :)
…________________________________
Van: Felix Bühler ***@***.***>
Verzonden: Monday, August 12, 2024 9:09:41 PM
Aan: riemers/ansible-gitlab-runner ***@***.***>
CC: Erik-jan Riemers ***@***.***>; Comment ***@***.***>
Onderwerp: Re: [riemers/ansible-gitlab-runner] ansible 2.16: add docker dependency (PR #342)
yes you are right. it is more an optional one. marked it as comment. or do you want this to be in the README?
—
Reply to this email directly, view it on GitHub<#342 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOMIVHKQG7YGCU6EWSDZREB7LAVCNFSM6AAAAABMMW3DYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUG4ZDMMJTGQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Stunkymonkey
force-pushed
the
ansible-2.16-add-docker-dependency
branch
from
7e3cf51
to
88abf39
Compare
|
@riemers of wow. there a quite a few linter errors showing up... |
|
Doesn’t like comments? There is a PR with better linter support but it’s stalled atm..
…________________________________
Van: Felix Bühler ***@***.***>
Verzonden: Monday, August 12, 2024 9:35:48 PM
Aan: riemers/ansible-gitlab-runner ***@***.***>
CC: Erik-jan Riemers ***@***.***>; Mention ***@***.***>
Onderwerp: Re: [riemers/ansible-gitlab-runner] ansible 2.16: add docker dependency (PR #342)
@riemers<https://github.com/riemers> of wow. there a quite a few linter errors showing up...
—
Reply to this email directly, view it on GitHub<#342 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOPUGDHUZBMRRBFE5QLZREFBJAVCNFSM6AAAAABMMW3DYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUG43DONJZGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@riemers do you suggest not touching the linter at all? then i simply remove the last commit. |
Closed
|
you can touch it, as long as it stil works after wards, the test don't do much atm. Also need to get free credit but thats always a pain with the CI team |
|
will be fixed via #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in ansible 2.16 the
docker_containeris no longer available. When installing the collectioncommunity.dockerit works.