forked from wildfly/wildfly
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request wildfly#18017 from bstansberry/WFLY-19287
[WFLY-19287] Fail boot if EE 11 APIs are used and the security manage…
- Loading branch information
Showing
9 changed files
with
209 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
...rc/test/java/org/wildfly/test/manual/securitymanager/SecurityManagerRejectedTestCase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /* | ||
| * Copyright The WildFly Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package org.wildfly.test.manual.securitymanager; | ||
|
|
||
| import static org.junit.Assert.assertFalse; | ||
|
|
||
| import org.jboss.arquillian.container.test.api.ContainerController; | ||
| import org.jboss.arquillian.container.test.api.RunAsClient; | ||
| import org.jboss.arquillian.junit.Arquillian; | ||
| import org.jboss.arquillian.test.api.ArquillianResource; | ||
| import org.jboss.as.test.shared.util.AssumeTestGroupUtil; | ||
| import org.junit.After; | ||
| import org.junit.AssumptionViolatedException; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.wildfly.core.testrunner.ServerControl; | ||
|
|
||
| /** | ||
| * Tests that starting a server with the SecurityManager enabled fails in an EE11 environment | ||
| */ | ||
| @RunAsClient() | ||
| @RunWith(Arquillian.class) | ||
| @ServerControl(manual = true) | ||
| public class SecurityManagerRejectedTestCase { | ||
|
|
||
| private static final String SERVER_CONFIG_NAME = "forced-security-manager"; | ||
| @ArquillianResource | ||
| private static volatile ContainerController containerController; | ||
|
|
||
| @BeforeClass | ||
| public static void ee11Only() { | ||
|
|
||
| // If we are running in a testsuite execution with the SM explicitly enabled everywhere, | ||
| // we can't be expecting servers to fail to boot with the SM. | ||
| // So no point going further | ||
| AssumeTestGroupUtil.assumeSecurityManagerDisabled(); | ||
|
|
||
| // Use a missing ManagedBean class as an indicator that we are in an EE 11+ environment. | ||
| try { | ||
| SecurityManagerRejectedTestCase.class.getClassLoader().loadClass("jakarta.annotation.ManagedBean"); | ||
| throw new AssumptionViolatedException("Not an EE 11+ environment"); | ||
| } catch (ClassNotFoundException e) { | ||
| // not found means we want the test | ||
| } | ||
| } | ||
|
|
||
| @After | ||
| public void ensureContainerStopped() { | ||
| // If the test fails, don't leave a running server behind | ||
| if (containerController.isStarted(SERVER_CONFIG_NAME)) { | ||
| containerController.stop(SERVER_CONFIG_NAME); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testServerStart() { | ||
| assertFalse(containerController.isStarted(SERVER_CONFIG_NAME)); | ||
| try { | ||
| // This config has -secmgr hard coded in its startup args, so it should fail to start | ||
| containerController.start(SERVER_CONFIG_NAME); | ||
| } catch (Exception ok) { | ||
| // good. fall through and confirm the effect of this is the container wasn't started | ||
| } | ||
| assertFalse(containerController.isStarted(SERVER_CONFIG_NAME)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
...rc/test/java/org/wildfly/test/manual/securitymanager/SecurityManagerRejectedTestCase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * Copyright The WildFly Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package org.wildfly.test.manual.securitymanager; | ||
|
|
||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.fail; | ||
|
|
||
| import org.jboss.arquillian.container.test.api.ContainerController; | ||
| import org.jboss.arquillian.container.test.api.RunAsClient; | ||
| import org.jboss.arquillian.junit.Arquillian; | ||
| import org.jboss.arquillian.test.api.ArquillianResource; | ||
| import org.jboss.as.test.shared.util.AssumeTestGroupUtil; | ||
| import org.junit.After; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.wildfly.core.testrunner.ServerControl; | ||
|
|
||
| /** | ||
| * Tests that starting a server with the SecurityManager enabled fails in an EE11 environment | ||
| */ | ||
| @RunAsClient() | ||
| @RunWith(Arquillian.class) | ||
| @ServerControl(manual = true) | ||
| public class SecurityManagerRejectedTestCase { | ||
|
|
||
| private static final String SERVER_CONFIG_NAME = "forced-security-manager"; | ||
| @ArquillianResource | ||
| private static volatile ContainerController containerController; | ||
|
|
||
| @BeforeClass | ||
| public static void ee11Only() { | ||
|
|
||
| // If we are running in a testsuite execution with the SM explicitly enabled everywhere, | ||
| // we can't be expecting servers to fail to boot with the SM. | ||
| // So no point going further | ||
| AssumeTestGroupUtil.assumeSecurityManagerDisabled(); | ||
|
|
||
| // Use a missing ManagedBean class as an indicator that we are in an EE 11+ environment. | ||
| try { | ||
| SecurityManagerRejectedTestCase.class.getClassLoader().loadClass("jakarta.annotation.ManagedBean"); | ||
| // BES 2024/07/06 -- I've considered supporting ManagedBean in an EE 11+ env; if we do that it would | ||
| // likely require making the class available on the test classpath so test deployments can compile. | ||
| // If we do that this test should fail, so we can switch to a different mechanism for deciding if it | ||
| // should run or not. Check for this when testing WildFly Preview which no longer supports EE 10. | ||
| fail("Update this test if we begin putting ManagedBean on the classpath in an EE 11 environment"); | ||
| } catch (ClassNotFoundException e) { | ||
| // not found means we want the test | ||
| } | ||
| } | ||
|
|
||
| @After | ||
| public void ensureContainerStopped() { | ||
| // If the test fails, don't leave a running server behind | ||
| if (containerController.isStarted(SERVER_CONFIG_NAME)) { | ||
| containerController.stop(SERVER_CONFIG_NAME); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testServerStart() { | ||
| assertFalse(containerController.isStarted(SERVER_CONFIG_NAME)); | ||
| try { | ||
| // This config has -secmgr hard coded in its startup args, so it should fail to start | ||
| containerController.start(SERVER_CONFIG_NAME); | ||
| } catch (Exception ok) { | ||
| // good. fall through and confirm the effect of this is the container wasn't started | ||
| } | ||
| assertFalse(containerController.isStarted(SERVER_CONFIG_NAME)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters