Skip to content

Commit

Permalink
✅ Exclude incompatible versions from CI matrix
Browse files Browse the repository at this point in the history
With a little effort, some of these could be made compatible, but...
it's really not worth the effort.  We'll be dropping support for older
versions from the next minor release anyway.
  • Loading branch information
nevans committed May 16, 2024
1 parent 84f3153 commit 8f762a3
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,19 @@ jobs:
resque: "2.6"
redis: "5.2"

exclude:
- { redis: "5.0", ruby: "2.4" } # redis 5.0 requires ruby 2.5
- { redis: "5.2", ruby: "2.4" } # redis 5.2 requires ruby 2.6
- { redis: "5.2", ruby: "2.5" } # redis 5.2 requires ruby 2.6

# ironically, resque 1.22 seems to be compatible with ruby 3+
- { resque: "1.23", ruby: "3.0" } # incompatible with ruby 3+
- { resque: "1.24", ruby: "3.1" } # incompatible with ruby 3+
- { resque: "1.25", ruby: "3.2" } # incompatible with ruby 3+

- { resque: "2.1", ruby: "3.0" } # redis-namespace 1.7 requires ruby < 3
- { resque: "2.1", ruby: "3.1" } # redis-namespace 1.7 requires ruby < 3
- { resque: "2.1", ruby: "3.2" } # redis-namespace 1.7 requires ruby < 3

services:
redis:
Expand Down

0 comments on commit 8f762a3

Please sign in to comment.