Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.12.0 #142

Merged
merged 23 commits into from
Sep 19, 2024
Merged

Release 5.12.0 #142

merged 23 commits into from
Sep 19, 2024

Conversation

APiankouski
Copy link
Contributor

No description provided.


protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class);
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'LOGGER' must contain no more than '1' consecutive capital letters.


protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class);
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck> reported by reviewdog 🐶
Member name 'LOGGER' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.

public SimpleElasticSearchClient(@Value("${rp.elasticsearch.host}") String host,
@Value("${rp.elasticsearch.username:}") String username,
@Value("${rp.elasticsearch.password:}") String password) {
public SimpleSearchEngineClient(@Value("${rp.searchengine.host}") String host,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.

private static final String GA_URL = "https://www.google-analytics.com/mp/collect?measurement_id=%s&api_secret=%s";
private static final String DATE_BEFORE = "date_before";

private static final String SELECT_INSTANCE_ID_QUERY = "SELECT value FROM server_settings WHERE key = 'server.details.instance';";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 132).

private static final String DATE_BEFORE = "date_before";

private static final String SELECT_INSTANCE_ID_QUERY = "SELECT value FROM server_settings WHERE key = 'server.details.instance';";
private static final String SELECT_STATISTICS_QUERY = "SELECT * FROM analytics_data WHERE type = 'DEFECT_UPDATE_STATISTICS' AND created_at >= :date_before::TIMESTAMP;";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 170).

}
// eventPublisher.publishEvent(new ElementsDeletedEvent(launchIds,
// projectId, numberOfLaunchElements));
// LOGGER.info("Send event with elements deleted number {} for
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 107).

}
// eventPublisher.publishEvent(new ElementsDeletedEvent(launchIds,
// projectId, numberOfLaunchElements));
// LOGGER.info("Send event with elements deleted number {} for
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// eventPublisher.publishEvent(new ElementsDeletedEvent(launchIds,
// projectId, numberOfLaunchElements));
// LOGGER.info("Send event with elements deleted number {} for
// project {}", deleted, projectId);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

@Configuration
public class JacksonConfiguration {

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

…or 'Regular' launches (#144)

(cherry picked from commit 7e028b2)
Copy link

sonarcloud bot commented Sep 19, 2024

@APiankouski APiankouski merged commit 2f32779 into master Sep 19, 2024
9 checks passed
@APiankouski APiankouski deleted the rc/5.12.0 branch September 19, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants