-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.12.0 #142
Release 5.12.0 #142
Conversation
EPMRPP-84831 || Update Gradle build script
…into rc/5.11.0 � Conflicts: � build.gradle
Merege Rc/5.11.0
EPMRPP-90182 || Update JDBC Driver to the latest
Merge hotfix/5.11.1
…ip-important EPMRPP-90918 || Jobs should skip important
* EPMRPP-88736 implement send analytics job
|
||
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class); | ||
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'LOGGER' must contain no more than '1' consecutive capital letters.
|
||
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class); | ||
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member name 'LOGGER' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
public SimpleElasticSearchClient(@Value("${rp.elasticsearch.host}") String host, | ||
@Value("${rp.elasticsearch.username:}") String username, | ||
@Value("${rp.elasticsearch.password:}") String password) { | ||
public SimpleSearchEngineClient(@Value("${rp.searchengine.host}") String host, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a Javadoc comment.
private static final String GA_URL = "https://www.google-analytics.com/mp/collect?measurement_id=%s&api_secret=%s"; | ||
private static final String DATE_BEFORE = "date_before"; | ||
|
||
private static final String SELECT_INSTANCE_ID_QUERY = "SELECT value FROM server_settings WHERE key = 'server.details.instance';"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 132).
private static final String DATE_BEFORE = "date_before"; | ||
|
||
private static final String SELECT_INSTANCE_ID_QUERY = "SELECT value FROM server_settings WHERE key = 'server.details.instance';"; | ||
private static final String SELECT_STATISTICS_QUERY = "SELECT * FROM analytics_data WHERE type = 'DEFECT_UPDATE_STATISTICS' AND created_at >= :date_before::TIMESTAMP;"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 170).
} | ||
// eventPublisher.publishEvent(new ElementsDeletedEvent(launchIds, | ||
// projectId, numberOfLaunchElements)); | ||
// LOGGER.info("Send event with elements deleted number {} for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 107).
} | ||
// eventPublisher.publishEvent(new ElementsDeletedEvent(launchIds, | ||
// projectId, numberOfLaunchElements)); | ||
// LOGGER.info("Send event with elements deleted number {} for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// eventPublisher.publishEvent(new ElementsDeletedEvent(launchIds, | ||
// projectId, numberOfLaunchElements)); | ||
// LOGGER.info("Send event with elements deleted number {} for | ||
// project {}", deleted, projectId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
import org.springframework.context.annotation.Bean; | ||
import org.springframework.context.annotation.Configuration; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary javadoc is missing.
@Configuration | ||
public class JacksonConfiguration { | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary javadoc is missing.
Quality Gate passedIssues Measures |
No description provided.