EPMRPP-82701 || Update Search configs and naming #127
Conversation
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class); | ||
| protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class); |
There was a problem hiding this comment.
Abbreviation in name 'LOGGER' must contain no more than '1' consecutive capital letters.
|
|
||
| protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class); | ||
| protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class); |
There was a problem hiding this comment.
Member name 'LOGGER' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
| public SimpleElasticSearchClient(@Value("${rp.elasticsearch.host}") String host, | ||
| @Value("${rp.elasticsearch.username:}") String username, | ||
| @Value("${rp.elasticsearch.password:}") String password) { | ||
| public SimpleSearchEngineClient(@Value("${rp.searchengine.host}") String host, |
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -68,16 +68,16 @@ void removeLogs() { | |||
|
|
|||
| final List<Long> launchIds = getLaunchIds(projectId, lessThanDate); | |||
| if (!launchIds.isEmpty()) { | |||
| deleteLogsFromElasticsearchByLaunchIdsAndProjectId(launchIds, projectId); | |||
| deleteLogsFromSearchEngineByLaunchIdsAndProjectId(launchIds, projectId); | |||
There was a problem hiding this comment.
'if' child has incorrect indentation level 10, expected level should be 22.
| @@ -77,7 +77,7 @@ private void removeLaunches() { | |||
| indexerServiceClient.removeFromIndexLessThanLaunchDate(projectId, lessThanDate); | |||
| LOGGER.info("Send message for deletion to analyzer for project {}", projectId); | |||
|
|
|||
| deleteLogsFromElasticsearchByLaunchIdsAndProjectId(launchIds, projectId); | |||
| deleteLogsFromSearchEngineByLaunchIdsAndProjectId(launchIds, projectId); | |||
There was a problem hiding this comment.
'if' child has incorrect indentation level 10, expected level should be 22.
No description provided.