Fixes SDK version fetch for "Distributing" lab #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR ----- Uses the SDK version directly in "Distributing" lab Details ------- Repairs a regression created by the switch from using the git tag ot the registry tag to find the SDK version. When the code used the git tag we had to strip the first character and with the registry version we don't. This fix makes sure we don't strip it.
crdant
changed the title
|
@xavpaice … I'll tap you on the shoulder, but I'd love to get a read on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Uses the SDK version directly in "Distributing" lab
Details
Repairs a regression created by the switch from using the git tag ot the
registry tag to find the SDK version. When the code used the git tag we
had to strip the first character and with the registry version we don't.
This fix makes sure we don't strip it.