SCIENCE-247 - reset lock on fork #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VOvchinnikov
force-pushed
the
reset-lock-on-fork-process
branch
from
1ad5002
to
5b9acd5
Compare
In `2.33` Google added some changes that make tests with anything Google being very slow. When `fsspec`/`gcsfs` people fix this, the limitation could be lifted
VOvchinnikov
force-pushed
the
reset-lock-on-fork-process
branch
from
5b9acd5
to
d8d6512
Compare
VOvchinnikov
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fsspechags when is used in a worker thread ofThreadPoolExecutor, releasing lock in the parent process before forking should help fix this issue.