Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick commit from V2 #34

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

mahavrila
Copy link
Collaborator

I forgot to rebase V3 branch on the recent V2 updates and one commit is therefore missing in V3. Fixing.

First automated tests used 'su' as a mean of testing smart card authentication.
However, these tests were usually supposed to test login (not su), but support
for any direct or indirect testing of login was not implemented yet. Testing
logins in TTY and also in GUI is already supported. It's time to check test
coverage and cover TCs that still use 'su' also with TTY and GUI logins.
Copy link
Collaborator

@GeorgePantelakis GeorgePantelakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahavrila mahavrila merged commit 291fd07 into redhat-qe-security:V3 Dec 22, 2023
1 check passed
GeorgePantelakis added a commit that referenced this pull request Jun 28, 2024
First automated tests used 'su' as a mean of testing smart card authentication.
However, these tests were usually supposed to test login (not su), but support
for any direct or indirect testing of login was not implemented yet. Testing
logins in TTY and also in GUI is already supported. It's time to check test
coverage and cover TCs that still use 'su' also with TTY and GUI logins.

Co-authored-by: George Pantelakis <gpantela@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants