Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kafka logging #803

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Improve kafka logging #803

merged 1 commit into from
Aug 7, 2023

Conversation

bradengroom
Copy link
Member

@bradengroom bradengroom commented Aug 4, 2023 •
edited
Loading

💸 TL;DR

We recently upgraded our version of confluent-kafka. All of our consumers stopped working and all we got was "skipping invalid message" text in sentry with no stacktrace. using logger.exception instead of logger.error should propagate the stacktrace and make this much more useful.

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@bradengroom bradengroom requested a review from a team as a code owner August 4, 2023 16:21
@bradengroom bradengroom merged commit fa188fe into develop Aug 7, 2023
3 checks passed
@bradengroom bradengroom deleted the improve-kafka-logging branch August 7, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KTAtkinson KTAtkinson KTAtkinson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradengroom @KTAtkinson