Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix textual access mode inference with FXL #81

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix textual access mode inference with FXL #81

merged 2 commits into from
Sep 6, 2023

Conversation

mickael-menu
Copy link
Member

  • We can't really infer a textual access mode with a FXL EPUB, even if it doesn't contain any image, because the DOM itself might be garbled (e.g. absolute positioning of letters/words). The inference was updated to only check reflowable EPUBs.
  • EPUB manifest items that are fallbacks of a spine item are now also added to the resources list in the RWPM. Often, these resources are actually embedded in the main XHTML resource. Not having them in resources produced false positives in the a11y inference as the bitmaps in Link.children were not taken into account.

chocolatkey
chocolatkey approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@chocolatkey chocolatkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickael-menu mickael-menu merged commit 70e1626 into main Sep 6, 2023
1 check passed
@mickael-menu mickael-menu deleted the fix/inference-access-text branch September 6, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chocolatkey chocolatkey chocolatkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickael-menu @chocolatkey