Hotifx: image paths (#23)

reactwaylabs · Jul 29, 2019 · e9e1e49 · e9e1e49
1 parent 163e398
commit e9e1e49
Show file tree

Hide file tree

Showing 14 changed files with 27 additions and 31 deletions.
diff --git a/common/config/rush/version-policies.json b/common/config/rush/version-policies.json
@@ -14,6 +14,6 @@
     "policyName": "WebpackBuilderPolicy",
     "mainProject": "@reactway/webpack-builder",
     "nextBump": "prerelease",
-    "version": "1.0.0-alpha.20"
+    "version": "1.0.0-alpha.21"
   }
 ]
diff --git a/packages/webpack-builder-plugin-clean/package.json b/packages/webpack-builder-plugin-clean/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/webpack-builder-plugin-clean",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A plugin made for webpack-builder.",
   "keywords": [
     "webpack",
@@ -31,7 +31,7 @@
     "**/*.md"
   ],
   "dependencies": {
-    "@reactway/webpack-builder": "1.0.0-alpha.20",
+    "@reactway/webpack-builder": "1.0.0-alpha.21",
     "clean-webpack-plugin": "^2.0.1",
     "webpack": "^4.31.0",
     "tslib": "^1.9.3",

diff --git a/packages/webpack-builder-plugin-html/package.json b/packages/webpack-builder-plugin-html/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/webpack-builder-plugin-html",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A plugin made for webpack-builder.",
   "keywords": [
     "webpack",
@@ -31,7 +31,7 @@
     "**/*.md"
   ],
   "dependencies": {
-    "@reactway/webpack-builder": "1.0.0-alpha.20",
+    "@reactway/webpack-builder": "1.0.0-alpha.21",
     "tslib": "^1.9.3",
     "html-webpack-plugin": "^3.2.0",
     "html-webpack-template": "^6.2.0",

diff --git a/packages/webpack-builder-plugin-image-loader/package.json b/packages/webpack-builder-plugin-image-loader/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/image-loader",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A plugin made for webpack to load images, optimize and resize.",
   "keywords": [
     "webpack",

diff --git a/packages/webpack-builder-plugin-image-loader/src/@types/globals.d.ts b/packages/webpack-builder-plugin-image-loader/src/@types/globals.d.ts
diff --git a/packages/webpack-builder-plugin-image-loader/src/__tests__/__snapshots__/plugin.test.ts.snap b/packages/webpack-builder-plugin-image-loader/src/__tests__/__snapshots__/plugin.test.ts.snap
diff --git a/packages/webpack-builder-plugin-image-loader/src/__tests__/plugin.test.ts b/packages/webpack-builder-plugin-image-loader/src/__tests__/plugin.test.ts
@@ -2,9 +2,6 @@ import webpack from "webpack";
 import webpackCompiler from "./compiler/compiler";
 import { ReactwayImageLoaderPlugin } from "../plugin";
 
-// tslint:disable-next-line:no-any
-(global as any).__webpack_public_path__ = "";
-
 describe("ReactwayImagePlugin displaying stats", () => {
     it("Adding plugin to config", async () => {
         const loader: webpack.RuleSetRule[] = [

diff --git a/packages/webpack-builder-plugin-image-loader/src/image-loader.ts b/packages/webpack-builder-plugin-image-loader/src/image-loader.ts
@@ -199,7 +199,7 @@ class ImageLoader {
             content: contentBuffer
         });
 
-        const path = `${__webpack_public_path__} + ${JSON.stringify(url)}`;
+        const path = `${JSON.stringify(url)}`;
 
         // If 'optimizeImagesInDev' value set to 'true' then every build check if files(images) exists in output dir is skipped.
         if (!options.optimizeImagesInDev) {

diff --git a/packages/webpack-builder-plugin-images/package.json b/packages/webpack-builder-plugin-images/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/webpack-builder-plugin-images",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A plugin made for webpack-builder.",
   "keywords": [
     "webpack",
@@ -30,8 +30,8 @@
     "**/*.md"
   ],
   "dependencies": {
-    "@reactway/webpack-builder": "1.0.0-alpha.20",
-    "@reactway/image-loader": "1.0.0-alpha.20",
+    "@reactway/webpack-builder": "1.0.0-alpha.21",
+    "@reactway/image-loader": "1.0.0-alpha.21",
     "tslib": "^1.9.3",
     "url-loader": "^1.1.2",
     "upath": "^1.1.2"

diff --git a/packages/webpack-builder-plugin-styles/package.json b/packages/webpack-builder-plugin-styles/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/webpack-builder-plugin-styles",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A plugin made for webpack-builder.",
   "keywords": [
     "webpack",
@@ -30,7 +30,7 @@
     "**/*.md"
   ],
   "dependencies": {
-    "@reactway/webpack-builder": "1.0.0-alpha.20",
+    "@reactway/webpack-builder": "1.0.0-alpha.21",
     "optimize-css-assets-webpack-plugin": "^5.0.1",
     "mini-css-extract-plugin": "^0.6.0",
     "fs-extra": "^8.0.1",

diff --git a/packages/webpack-builder-plugin-typescript/package.json b/packages/webpack-builder-plugin-typescript/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/webpack-builder-plugin-typescript",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A plugin made for webpack-builder.",
   "keywords": [
     "webpack",
@@ -32,7 +32,7 @@
   "dependencies": {
     "@babel/core": "^7.3.4",
     "@babel/preset-env": "^7.4.3",
-    "@reactway/webpack-builder": "1.0.0-alpha.20",
+    "@reactway/webpack-builder": "1.0.0-alpha.21",
     "babel-loader": "^8.0.5",
     "babel-plugin-syntax-dynamic-import": "^6.18.0",
     "fork-ts-checker-webpack-plugin": "^1.0.0",

diff --git a/packages/webpack-builder-plugin-web-dev/package.json b/packages/webpack-builder-plugin-web-dev/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/webpack-builder-plugin-web-dev",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A plugin made for webpack-builder.",
   "keywords": [
     "webpack",
@@ -31,7 +31,7 @@
     "**/*.md"
   ],
   "dependencies": {
-    "@reactway/webpack-builder": "1.0.0-alpha.20",
+    "@reactway/webpack-builder": "1.0.0-alpha.21",
     "tslib": "^1.9.3",
     "upath": "^1.1.2"
   },

diff --git a/packages/webpack-builder-plugin-write-file/package.json b/packages/webpack-builder-plugin-write-file/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/webpack-builder-plugin-write-file",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A plugin made for webpack-builder.",
   "keywords": [
     "webpack",
@@ -31,7 +31,7 @@
     "**/*.md"
   ],
   "dependencies": {
-    "@reactway/webpack-builder": "1.0.0-alpha.20",
+    "@reactway/webpack-builder": "1.0.0-alpha.21",
     "tslib": "^1.9.3",
     "write-file-webpack-plugin": "^4.5.0",
     "upath": "^1.1.2"

diff --git a/packages/webpack-builder/package.json b/packages/webpack-builder/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@reactway/webpack-builder",
-  "version": "1.0.0-alpha.20",
+  "version": "1.0.0-alpha.21",
   "description": "A tool to create webpack config easier using plugins.",
   "keywords": [
     "webpack",