Blocked currencies KWD, OMR, BHD. #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramth05
reviewed
Nov 7, 2023
Controller/Payment/Order.php
Outdated
| $currency === "OMR" or | ||
| $currency === "BHD") | ||
| { | ||
| throw new \Exception($currency . " currency is not supported at the moment."); |
There was a problem hiding this comment.
@yashgit891 , please return response same like error so that it can be used. No need to throw the exception. Also log it.
There was a problem hiding this comment.
same like this one
'message' => 'Unable to create your order. Please contact support.',
'parameters' => []
];
ramth05
reviewed
Nov 7, 2023
Controller/Payment/Order.php
Outdated
| @@ -249,10 +249,19 @@ public function execute() | |||
| . " and amount:" . $amount); | |||
| // @codeCoverageIgnoreEnd | |||
|
|
|||
| $currency = $mazeOrder->getOrderCurrencyCode(); | |||
|
|
|||
| if ($currency === "KWD" or | |||
There was a problem hiding this comment.
@yashgit891 , also please an array for the same. use in array
ramth05
reviewed
Nov 8, 2023
Controller/Payment/Order.php
Outdated
| @@ -249,10 +249,30 @@ public function execute() | |||
| . " and amount:" . $amount); | |||
| // @codeCoverageIgnoreEnd | |||
|
|
|||
| $currency = $mazeOrder->getOrderCurrencyCode(); | |||
|
|
|||
| if (in_array($currency, ["KWD", "BHD", "OMR"])) | |||
There was a problem hiding this comment.
Also define these currency as const array as well.
ramth05
reviewed
Nov 8, 2023
Controller/Payment/Order.php
Outdated
| @@ -249,10 +249,30 @@ public function execute() | |||
| . " and amount:" . $amount); | |||
| // @codeCoverageIgnoreEnd | |||
|
|
|||
| $currency = $mazeOrder->getOrderCurrencyCode(); | |||
There was a problem hiding this comment.
@yashgit891 , lets use it directly here, we don't to assign it new var
ramth05
reviewed
Nov 8, 2023
| @@ -132,6 +134,11 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value | |||
| ]; | |||
| } | |||
|
|
|||
| if (in_array($order_currency_code, static::THREE_DECIMAL_CURRENCIES) === true) | |||
| { | |||
| throw new \Exception($order_currency_code . " currency is not supported at the moment."); | |||
There was a problem hiding this comment.
@yashgit891 , please add info log here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.