-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pins on geospatial libraries, RAPIDS nightlies #722
Open
jameslamb
wants to merge
4
commits into
rapidsai:branch-24.10
Choose a base branch
from
jameslamb:fmt-and-spdlog
base: branch-24.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
changed the title
WIP: remove pins on geospatial libraries, specific RAPIDS nightlies
WIP: remove pins on geospatial libraries, most RAPIDS nightlies
Sep 19, 2024
This reverts commit de8c29c.
jameslamb
changed the title
WIP: remove pins on geospatial libraries, most RAPIDS nightlies
WIP: remove pins on geospatial libraries, RAPIDS nightlies
Sep 19, 2024
🎉 looks like it's possible to solve an environment with all of RAPIDS + the newer versions of
|
jameslamb
changed the title
WIP: remove pins on geospatial libraries, RAPIDS nightlies
[DO NOT MERGE] remove pins on geospatial libraries, RAPIDS nightlies
Sep 19, 2024
jameslamb
changed the title
[DO NOT MERGE] remove pins on geospatial libraries, RAPIDS nightlies
remove pins on geospatial libraries, RAPIDS nightlies
Sep 19, 2024
jameslamb
requested review from
AyodeAwe and
bdice
and removed request for
AyodeAwe
September 19, 2024 16:56
bdice
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart move! I wouldn't have thought to test this repository in CI as a part of the fmt/spdlog migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#56
With rapidsai/cuspatial#1441, it should be possible to revert some of the workarounds introduced in #719.
Notes for Reviewers
How to test this
if this is working, we should see the following in the conda solves:
fmt >=11.0.2
spdlog >=1.14.1
We won't see
numpy >=2
yet, because thecugraph
doesn't support it yet.