Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using native traceback #16851

Open
wants to merge 6 commits into
base: branch-24.10
Choose a base branch
from
Open

Switch to using native traceback #16851

wants to merge 6 commits into from
+25 −0

Conversation

galipremsagar
Copy link
Contributor

Description

This PR switches pytest traceback to native instead of prettified pytest traceback that takes longer to finish and spits out the source code of the file where the error happens too which is not needed given the time savings.

With pytest traceback:
Screenshot 2024-09-19 at 2 34 57 PM
Screenshot 2024-09-19 at 2 35 07 PM
Screenshot 2024-09-19 at 2 35 20 PM

With native traceback:
Screenshot 2024-09-19 at 2 34 04 PM

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 19, 2024
@galipremsagar galipremsagar self-assigned this Sep 19, 2024
@galipremsagar galipremsagar marked this pull request as ready for review September 19, 2024 19:46
@galipremsagar galipremsagar requested a review from a team as a code owner September 19, 2024 19:46
bdice
bdice approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me. We could alternatively set this with the config options:

[pytest]
addopts = --tb=native

@galipremsagar galipremsagar requested review from a team as code owners September 19, 2024 22:03
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars labels Sep 19, 2024
@galipremsagar
Copy link
Contributor Author

This is fine with me. We could alternatively set this with the config options:

[pytest]
addopts = --tb=native

Move it to config options.

rjzamora
rjzamora approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galipremsagar - Seems fine on the dask side.

ci/test_wheel_dask_cudf.sh
@@ -41,6 +41,7 @@ pushd python/dask_cudf/dask_cudf
DASK_DATAFRAME__QUERY_PLANNING=True python -m pytest \
--junitxml="${RAPIDS_TESTS_DIR}/junit-dask-cudf.xml" \
--numprocesses=8 \
--dist=worksteal \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how much of a speedup you see with this change?

Copy link
Contributor Author

@galipremsagar galipremsagar Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we switched cudf wide, we were able to cut down 25% of the execution time: #15207 (comment)

@galipremsagar
Copy link
Contributor Author

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@rjzamora rjzamora rjzamora approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/ci-codeowners

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @bdice @rjzamora