Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made cudftestutil header-only and removed GTest dependency #16839

Open
wants to merge 3 commits into
base: branch-24.10
Choose a base branch
from

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Sep 19, 2024

Description

This merge request follows up on #16658.
It converts cudftestutil's .cpp & .cu source files into a header source file that should be included into one translation unit at the point of consumption.
It also removes the dependency on GTest by cudftestutil. It satisfies the requirement that we only need API compatibility with the GTest API and we don't expose the gtest symbols to our consumers.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lamarrr lamarrr added feature request New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 19, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 19, 2024
@lamarrr lamarrr marked this pull request as ready for review September 19, 2024 10:58
@github-actions github-actions bot added the CMake CMake build issue label Sep 19, 2024
@lamarrr lamarrr requested review from a team as code owners September 19, 2024 10:58
@lamarrr lamarrr added feature request New feature or request and removed improvement Improvement / enhancement to an existing function feature request New feature or request labels Sep 19, 2024
@lamarrr lamarrr force-pushed the cudftestutil-header branch 4 times, most recently from 00514f7 to d55a6ab Compare September 19, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant