Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook that validated users RBAC rules #732

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

Add a validating webhook for ETCD snapshot and restore that validates users permissions for the referenced cluster object.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #721

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexander-demicev alexander-demicev merged commit a253f96 into rancher:main Sep 16, 2024
9 checks passed
@alexander-demicev alexander-demicev deleted the rbacwebhook branch September 16, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Verify users RBAC when creating a snapshot/restore
3 participants