-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapshot sync controller #718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
sync
branch
2 times, most recently
from
September 5, 2024 09:22
419ba6c
to
cc8a6ca
Compare
alexander-demicev
force-pushed
the
sync
branch
from
September 5, 2024 09:48
cc8a6ca
to
2dbe4a3
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits, thanks for PR
Edit: please also rebase after recent changes merged
charts/rancher-turtles/templates/rancher-turtles-exp-etcdrestore-components.yaml
Show resolved
Hide resolved
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
sync
branch
from
September 5, 2024 12:54
2dbe4a3
to
30076ff
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
sync
branch
from
September 5, 2024 13:42
bc7fee9
to
d456669
Compare
furkatgofurov7
approved these changes
Sep 5, 2024
Danil-Grigorev
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add snapshot sync controller, I will add tests in a follow-up PR
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #501
Special notes for your reviewer:
Checklist: