update version skew policy #833
Conversation
This commit updates the version skew policy to match this document: https://kubernetes.io/releases/version-skew-policy/
|
@mjura @yiannistri folks, can you please take a look when you have time? Thanks |
|
@justdan96 thank you for the PR, could you also add tests that cover this change? I'll review the change itself in the meantime. |
|
@yiannistri test added |
|
@mjura I've tested this change locally and it looks fine from my point of view. Can you please also review? |
| @@ -353,11 +353,16 @@ func validateUpdate(config *eksv1.EKSClusterConfig) error { | |||
| if clusterVersion.EQ(*version) { | |||
| continue | |||
| } | |||
| if clusterVersion.Minor-version.Minor == 1 { | |||
| if (clusterVersion.Minor < 25 && clusterVersion.Minor-version.Minor <= 2) || (clusterVersion.Minor >= 25 && clusterVersion.Minor-version.Minor <= 3) { | |||
There was a problem hiding this comment.
Why it has to be lower than 25? We already dropped support for Kubernetes lower than 27. It doesn't make sense to me
| continue | ||
| } | ||
| errs = append(errs, fmt.Sprintf("versions for cluster [%s] and nodegroup [%s] not compatible: all nodegroup kubernetes versions"+ | ||
| "must be equal to or one minor version lower than the cluster kubernetes version", aws.ToString(config.Spec.KubernetesVersion), aws.ToString(ng.Version))) | ||
| if clusterVersion.Minor < 25 { |
There was a problem hiding this comment.
Again this same question, why 25 ?
| errs = append(errs, fmt.Sprintf("versions for cluster [%s] and nodegroup [%s] not compatible: all nodegroup kubernetes versions"+ | ||
| "must be equal to or one minor version lower than the cluster kubernetes version", aws.ToString(config.Spec.KubernetesVersion), aws.ToString(ng.Version))) | ||
| if clusterVersion.Minor < 25 { | ||
| errs = append(errs, fmt.Sprintf("versions for cluster [%s] and node group [%s] are not compatible: for clusters running Kubernetes < 1.25 the "+ |
There was a problem hiding this comment.
We already dropped support for Kubernetes lower than 1.27
|
I can't find a list of supported versions in this repo, are you talking about Rancher itself? Even if that's the case the v.2.8.x line still supports K8s 1.25. |
What this PR does / why we need it:
This commit updates the version skew policy to match this document: https://kubernetes.io/releases/version-skew-policy/
Which issue(s) this PR fixes
Issue #834
Special notes for your reviewer:
Checklist: