Skip to content

Commit

Permalink
Fix shadowed assignment
Browse files Browse the repository at this point in the history
Prior, a modified object error was encountered when updating phase
because object returned from earlier update was not assigned to
config in outer scope. Now, correct config variable is being used
and modified error is not encountered.
  • Loading branch information
rmweir committed Jun 16, 2020
1 parent 1de89ad commit a539a91
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion controller/eks-cluster-config-handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ func (h *Handler) create(config *v13.EKSClusterConfig, sess *session.Session, ek
config.Spec.Subnets = strings.Split(subnetIdsString, ",")
subnetIds = aws.StringSlice(config.Spec.Subnets)

config, err := h.eksCC.Update(config)
config, err = h.eksCC.Update(config)
if err != nil {
return config, err
}
Expand Down

0 comments on commit a539a91

Please sign in to comment.