-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming DCA #57
Streaming DCA #57
Conversation
bounty: min( | ||
linear-growth( | ||
bounty-min | ||
bounty-epoch-increase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought we discussed in chat just having a single time which is the total auction duration?
last-time: strat-strat-time; | ||
|
||
#get-last-time-prod | ||
current-time: block-timestamp(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be able to just use now()
for this
); | ||
|
||
#get-last-time-plot | ||
current-time: block-timestamp(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this actually do anything in the charts?
|
||
# Unix timestamp for strating of the strategy. | ||
#Ideally set it 15 minutes ahead of the whatever the timestamp is while deploying | ||
strat-strat-time: 1718738185 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start this at a very high number like 9999999999 so that it never accidentally drains, worst case is that it just accidentally never starts
bounty-amount: call<'bounty-auction>(elapsed-time), | ||
input-amount: call<'calculate-budget-input>(current-budget), | ||
max-amount: current-budget, | ||
io-ratio: div(saturating-sub(input-amount bounty-amount) current-budget), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've got a sat sub here on the numerator, is an io ratio of 0
actually allowed?
current-time last-time: call<'get-last-time>(), | ||
elapsed-time: saturating-sub(current-time last-time), | ||
current-budget: mul(per-second-rate elapsed-time), | ||
bounty-amount: call<'bounty-auction>(elapsed-time), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've got "elapsed-time" here but it is "time-since-cooldown" in the bounty calculation
if the bounty auction starts immediately then it is raising the gas it will pay while the overall output budget is still very small, which won't clear anyway
probably we only want to start the bounty auction after a certain amount of time has passed
@Siddharth2207 you should be able to pick this up again shortly - there is a space to get this completed |
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following: