-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollback contract address #51
Conversation
@hardyjosh @Siddharth2207 well actually i don't even think the readme should exist, shouldn't this actually be cross referenced against the settings file in our docs, and these addresses removed from the readme here? |
Yes I agree, there should be only source of truth for loading settings. Although the docs do not have OrderBook and Uniswap subparser addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so it seems it wasn't clear that i was rejecting the PR earlier
please delete the readme so that it doesn't exist to contradict the strats and tests
Removed. |
1 similar comment
Removed. |
@@ -38,7 +38,7 @@ subgraphs: | |||
|
|||
orderbooks: | |||
flare-pubstrats: | |||
address: 0x07701e3BcE4248EFDFc7D31392a43c8b82a7A260 | |||
address: 0xb06202aA3Fe7d85171fB7aA5f17011d17E63f382 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this in all the pubstrats that need it?
Motivation
Flare network
OrderBook
andRouteProcessorOrderBookV3ArbOrderTaker
need to match the ones provided under repo readme, as these are the contracts that are pinned and are indexed by the subgraph.Solution
Changed the contract addresses to match the pubstrat readme.