Update tranche-space dashboard #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidmeister
requested changes
May 19, 2024
src/tranche-space.rain
Outdated
| amount | ||
| io-ratio:, | ||
| input-amount: decimal18-mul(amount io-ratio), | ||
| effective-price: decimal18-inv(io-ratio); | ||
| effective-price: decimal18-inv(io-ratio), | ||
| effective-price-twap: decimal18-inv(tranche-io-ratio); |
There was a problem hiding this comment.
this isn't always a twap
There was a problem hiding this comment.
should i just rename effective-price-twap
There was a problem hiding this comment.
pushed a fix .
src/tranche-space.rain
Outdated
| @@ -481,7 +514,7 @@ deployments: | |||
| amount-available: decimal18-mul(tranche-total-size tranche-space-available), | |||
| amount: if(amount-is-output amount-available decimal18-div(amount-available final-io-ratio)), | |||
| io-ratio: final-io-ratio, | |||
| :call<'plottables>(amount io-ratio); | |||
| :call<'plottables>(tranche-io-ratio amount io-ratio); | |||
There was a problem hiding this comment.
we should show the multiplier
There was a problem hiding this comment.
sorry more context please, tranche-io-ratio is the multiplier what is it that needs to be shown ?
There was a problem hiding this comment.
Added the multiplier metric.
thedavidmeister
requested changes
May 29, 2024
src/tranche-space.rain
Outdated
| # the tranche size/ratio was denominated in USD, then the reference and | ||
| # reserve bindings need to be given along with the twap bindings | ||
| reference-stable: 0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9 | ||
| reference-stable-decimals: 6 |
There was a problem hiding this comment.
are the decimals needed?
There was a problem hiding this comment.
yes, they are passed as an argument for the uniswap twap call.
|
Closing this PR and putting a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Binding and charting buys and sells when twap identity is used for TKN tranche ratio denominations.
Solution
Add bindings for
tranche-spacewhen tranche ratio/base are denominated in token like WETH. Update theplottablesbinding, so the effective price denominated in USD can be plotted in the chart for when the twap identity is used for buys and sells.Checks
plottablesbinding to have effective price denominated in USD on the stack.