Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom slippage #1708

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix: custom slippage #1708

wants to merge 12 commits into from

Conversation

estebanmino
Copy link
Member

@estebanmino estebanmino commented Sep 23, 2024

Fixes BX-4828
Figma link (if any):

What changed (plus any additional context for devs)

custom slippage wasn't working on prod so e2e was sending swaps with a very low slippage value

also edited e2e flow to correctly type values in slippage and swaps input to make e2e work

Screen recordings / screenshots

What to test

@estebanmino estebanmino changed the title wip e2e fix: custom slippage Sep 24, 2024
@estebanmino estebanmino marked this pull request as ready for review September 24, 2024 21:37
Copy link

socket-security bot commented Sep 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rollup/rollup-android-arm-eabi@4.22.4 None 0 1.47 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-android-arm64@4.22.4 None 0 2.05 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-darwin-arm64@4.22.4 None 0 2.18 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-darwin-x64@4.22.4 None 0 2.32 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm-gnueabihf@4.22.4 None 0 2.22 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm-musleabihf@4.22.4 None 0 2.21 MB lukastaegert
npm/@rollup/rollup-linux-arm64-gnu@4.22.4 None 0 2.23 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm64-musl@4.22.4 None 0 2.12 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-powerpc64le-gnu@4.22.4 None 0 2.76 MB lukastaegert
npm/@rollup/rollup-linux-riscv64-gnu@4.22.4 None 0 2.25 MB lukastaegert
npm/@rollup/rollup-linux-s390x-gnu@4.22.4 None 0 3.8 MB lukastaegert
npm/@rollup/rollup-linux-x64-gnu@4.22.4 None 0 2.49 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-x64-musl@4.22.4 None 0 2.48 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-arm64-msvc@4.22.4 None 0 2.74 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-ia32-msvc@4.22.4 None 0 2.53 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-x64-msvc@4.22.4 None 0 3.28 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/rollup@4.22.4 None 0 2.27 MB eventualbuddha, lukastaegert, rich_harris, ...2 more
npm/zod@3.23.8 None 0 667 kB colinmcd94

🚮 Removed packages: npm/@rollup/rollup-android-arm-eabi@4.21.3, npm/@rollup/rollup-android-arm64@4.21.3, npm/@rollup/rollup-darwin-arm64@4.21.3, npm/@rollup/rollup-darwin-x64@4.21.3, npm/@rollup/rollup-linux-arm-gnueabihf@4.21.3, npm/@rollup/rollup-linux-arm-musleabihf@4.21.3, npm/@rollup/rollup-linux-arm64-gnu@4.21.3, npm/@rollup/rollup-linux-arm64-musl@4.21.3, npm/@rollup/rollup-linux-powerpc64le-gnu@4.21.3, npm/@rollup/rollup-linux-riscv64-gnu@4.21.3, npm/@rollup/rollup-linux-s390x-gnu@4.21.3, npm/@rollup/rollup-linux-x64-gnu@4.21.3, npm/@rollup/rollup-linux-x64-musl@4.21.3, npm/@rollup/rollup-win32-arm64-msvc@4.21.3, npm/@rollup/rollup-win32-ia32-msvc@4.21.3, npm/@rollup/rollup-win32-x64-msvc@4.21.3, npm/rollup@4.21.3, npm/zod@1.11.17

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants