Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update a lot of packages to fix ledger issues with chromedriver #1702

Closed
wants to merge 10 commits into from
Closed

update a lot of packages to fix ledger issues with chromedriver #1702

wants to merge 10 commits into from

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Sep 16, 2024 •
edited
Loading

What changed (plus any additional context for devs)

  • Updated packages to resolve Ledger issues with chromedriver
  • skipped some failing tests
  • will follow up with fixes for failing tests

@socket-security Socket Security
Copy link

socket-security bot commented Sep 16, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@bazel/runfiles@5.8.1 environment, filesystem 0 23.6 kB alexeagle
npm/@ledgerhq/cryptoassets@13.3.0 None 0 62 MB ldg-github-ci
npm/@ledgerhq/devices@8.4.2 None 0 222 kB ldg-github-ci
npm/@ledgerhq/domain-service@1.2.3 None 0 142 kB ldg-github-ci
npm/@ledgerhq/errors@6.18.0 None 0 205 kB ldg-github-ci
npm/@ledgerhq/evm-tools@1.2.0 None 0 131 kB ldg-github-ci
npm/@ledgerhq/hw-app-eth@6.38.0 None 0 2.16 MB ldg-github-ci
npm/@ledgerhq/hw-transport-mocker@6.29.2 None 0 107 kB ldg-github-ci
npm/@ledgerhq/hw-transport@6.31.2 None 0 132 kB ldg-github-ci
npm/@ledgerhq/live-env@2.2.0 None 0 262 kB ldg-github-ci
npm/@ledgerhq/live-network@1.4.0 None 0 127 kB ldg-github-ci
npm/@ledgerhq/live-promise@0.1.0 None 0 43.2 kB ldg-github-ci
npm/@ledgerhq/types-live@6.50.0 None 0 372 kB ldg-github-ci
npm/@rollup/rollup-android-arm-eabi@4.21.3 None 0 1.46 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-android-arm64@4.21.3 None 0 2.05 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-darwin-arm64@4.21.3 None 0 2.18 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-darwin-x64@4.21.3 None 0 2.33 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm-gnueabihf@4.21.3 None 0 2.22 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm-musleabihf@4.21.3 None 0 2.21 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm64-gnu@4.21.3 None 0 2.23 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm64-musl@4.21.3 None 0 2.12 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-powerpc64le-gnu@4.21.3 None 0 2.76 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-riscv64-gnu@4.21.3 None 0 2.24 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-s390x-gnu@4.21.3 None 0 3.81 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-x64-gnu@4.21.3 None 0 2.47 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-x64-musl@4.21.3 None 0 2.47 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-arm64-msvc@4.21.3 None 0 2.76 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-ia32-msvc@4.21.3 None 0 2.53 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-x64-msvc@4.21.3 None 0 3.27 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@tootallnate/quickjs-emscripten@0.23.0 filesystem, network 0 1.73 MB tootallnate
npm/ast-types@0.13.4 None 0 465 kB benjamn
npm/basic-ftp@5.0.5 filesystem, network 0 136 kB patrickjuchli
npm/chromedriver@128.0.3 environment, shell 0 45.4 kB giggio
npm/data-uri-to-buffer@6.0.2 None 0 16.8 kB tootallnate
npm/degenerator@5.0.1 None 0 27.1 kB tootallnate
npm/escodegen@2.1.0 None 0 109 kB michaelficarra
npm/get-uri@6.0.3 filesystem, network 0 44.3 kB tootallnate
npm/netmask@2.0.2 None 0 32.5 kB rs
npm/pac-proxy-agent@7.0.2 network 0 33.5 kB tootallnate
npm/pac-resolver@7.0.1 network 0 61.9 kB tootallnate
npm/proxy-agent@6.4.0 network 0 23.7 kB tootallnate
npm/rollup@4.21.3 None 0 2.27 MB eventualbuddha, lukastaegert, rich_harris, ...2 more
npm/selenium-webdriver@4.24.1 environment 0 18.2 MB pujagani
npm/vite@5.2.14 environment, eval, filesystem, network, shell, unsafe 0 3.6 MB vitebot

🚮 Removed packages: npm/@ledgerhq/cryptoassets@11.4.0, npm/@ledgerhq/devices@8.2.0, npm/@ledgerhq/domain-service@1.1.17, npm/@ledgerhq/errors@6.16.1, npm/@ledgerhq/evm-tools@1.0.14, npm/@ledgerhq/hw-app-eth@6.35.3, npm/@ledgerhq/hw-transport-mocker@6.28.2, npm/@ledgerhq/hw-transport@6.30.2, npm/@ledgerhq/live-env@0.9.0, npm/@ledgerhq/live-network@1.1.11, npm/@ledgerhq/live-promise@0.0.3, npm/@ledgerhq/types-live@6.44.0, npm/chromedriver@121.0.2, npm/lru-cache@7.18.3, npm/rollup@3.29.3, npm/selenium-webdriver@4.10.0, npm/vite@4.5.3

View full report↗︎

brunobar79
brunobar79 reviewed Sep 17, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
brunobar79
brunobar79 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

derHowie
derHowie requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have any takeaways when you attempted to get those tests working? Any idea what's going on? Merging those skips into master makes me nervous because then we'd be able to add more bugs to those flows without knowing.

.github/actions/chromeTestsSetup/action.yml
@@ -12,4 +12,4 @@ runs:
gh-access-token: ${{ inputs.gh-access-token }}
- name: Install chrome
shell: 'bash'
run: npx @puppeteer/browsers install chrome@121
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to keep repinning this? wondering if we should try to be @latest again.

Copy link
Member Author

@BrodyHughes BrodyHughes Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • yeah I originally changed it to that but some other errors happened and bruno pinned it. i am honestly down for either but doing @latest does require we update chromedriver regularly.
  • takeaways when trying to fix tests were I think we merged something in that broke it. the only thing currently broken is the actual executing swap. Here is the error i was seeing:
Screenshot 2024-09-17 at 1 34 18 AM
  • my thought was since bx is moving slow and this release should get out we can unblock CI and then solve it afterwards

@derHowie derHowie mentioned this pull request Sep 18, 2024
Merged
@BrodyHughes
Copy link
Member Author

Closed in favor of: #1704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie requested changes

@brunobar79 brunobar79 brunobar79 approved these changes

@DanielSinclair DanielSinclair Awaiting requested review from DanielSinclair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrodyHughes @brunobar79 @derHowie @DanielSinclair