swap seach popular in rainbow #1696
Draft
+135
−328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-schrammel
requested review from
walmat,
estebanmino,
derHowie and
benisgold
greg-schrammel
commented
Sep 9, 2024
Comment on lines
109
to
120
| isNativeAsset: [ | ||
| `${ETH_ADDRESS}_${ChainId.mainnet}`, | ||
| `${ETH_ADDRESS}_${ChainId.optimism}`, | ||
| `${ETH_ADDRESS}_${ChainId.arbitrum}`, | ||
| `${BNB_BSC_ADDRESS}_${ChainId.bsc}`, | ||
| `${MATIC_POLYGON_ADDRESS}_${ChainId.polygon}`, | ||
| `${ETH_ADDRESS}_${ChainId.base}`, | ||
| `${ETH_ADDRESS}_${ChainId.zora}`, | ||
| `${ETH_ADDRESS}_${ChainId.avalanche}`, | ||
| `${ETH_ADDRESS}_${ChainId.blast}`, | ||
| `${ETH_ADDRESS}_${ChainId.degen}`, | ||
| ].includes(`${a.uniqueId}_${chainId}`), |
There was a problem hiding this comment.
replaced this with isNativeAsset from ~/core/utils/chains, fixes some chains like degen that was not getting the right native
walmat
reviewed
Sep 10, 2024
Comment on lines
515
to
518
| if (popularAssets) { | ||
| sections.push({ id: 'popular', data: popularAssets }); | ||
| } | ||
|
|
There was a problem hiding this comment.
do we want to limit to 3 results like in the app?
benisgold
requested changes
Sep 13, 2024
| @@ -508,6 +512,10 @@ export function useSearchCurrencyLists({ | |||
| return sections; | |||
| } | |||
|
|
|||
| if (popularAssets) { | |||
There was a problem hiding this comment.
i think you need to make sure there is no overlap between assets in the popular section and assets in other sections. here's the app logic https://github.com/rainbow-me/rainbow/blob/develop/src/__swaps__/screens/Swap/hooks/useSearchCurrencyLists.ts
lmk if you want me to explain more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
Screen recordings / screenshots
Screen.Recording.2024-09-09.at.17.23.01.mov
What to test