Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public API more dotnet-ish #54

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

lukebakken
Copy link
Contributor

  • Add property for Name to IQueueSpecification
  • Rename Name() to SetName()

@lukebakken lukebakken self-assigned this Aug 27, 2024
@lukebakken lukebakken added this to the 0.1.0 milestone Aug 27, 2024
@lukebakken
Copy link
Contributor Author

@Gsantomaggio before I do more of these sorts of changes, I'd like your input. Having methods like Name() to get data from a class just feels too Java-ish to me 😉

@Gsantomaggio
Copy link
Member

@lukebakken you are right. That was a "copy and paste" from Java :)!

* Add property for `Name` to `IQueueSpecification`
* Rename `Name()` to `SetName()`

* Continue working on `IQueueSpecification`

* More `IQueueSpecification` changes.

* Start working on `IExchangeSpecification` changes

* More `IExchangeSpecification` tweaks

* Finish modifying `IExchangeSpecification`

* Start work on `IBindingSpecification`

* Better dotnet names, I think.

* More `IExchangeSpecification` renames

* More `IBindingSpecification` renames

* Finish `IBindingSpecification`

* Remove some classes from the public API
@lukebakken lukebakken marked this pull request as ready for review August 28, 2024 16:36
@lukebakken lukebakken merged commit 7faf7e0 into main Aug 28, 2024
2 checks passed
@lukebakken lukebakken deleted the lukebakken/dotnet-ify-api branch August 28, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants