[BOOST-4785] Correctly masking leading bits for incentives in SignerValidator #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sammccord
approved these changes
Sep 30, 2024
Quazia
approved these changes
Sep 30, 2024
| @@ -141,7 +142,7 @@ library IncentiveBits { | |||
| // toggle the value that was stored inline on stack with xor | |||
| let updatedStorageValue := xor(sload(storageSlot), shl(incentive, 1)) | |||
| // isolate the toggled bit and see if it's been unset back to zero | |||
| let alreadySet := xor(1, shr(incentive, updatedStorageValue)) | |||
| let alreadySet := xor(1, and(1, shr(incentive, updatedStorageValue))) | |||
There was a problem hiding this comment.
Legend has it you can build a whole computer with those things
topocount
force-pushed
the
kevin/boost-4785-fix-incentivebitssetorthrow-will-revert-leading-to-a-dos
branch
from
a5c7f04
to
5b1c4f2
Compare
We were only shifting the trailing bits off the stack but not masking the leading bits, leading to a situation where incentives could not be claimed out of order. This is fixed by and-masking against 1 after shifting the incentive index to the least significant bit.
topocount
force-pushed
the
kevin/boost-4785-fix-incentivebitssetorthrow-will-revert-leading-to-a-dos
branch
from
5b1c4f2
to
580e13c
Compare
topocount
deleted the
kevin/boost-4785-fix-incentivebitssetorthrow-will-revert-leading-to-a-dos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only shifting the trailing bits off the stack but not masking
the leading bits, leading to a situation where incentives could not be
claimed out of order.
This is fixed by and-masking against 1 after shifting the incentive index to
the least significant bit.