Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libsass with Dart Sass CLI #77

Merged
merged 5 commits into from
Feb 8, 2021
Merged

Replace libsass with Dart Sass CLI #77

merged 5 commits into from
Feb 8, 2021

Conversation

eritbh
Copy link
Member

@eritbh eritbh commented Jan 27, 2021

Among other things, this lets us take advantage of the modern Sass module system and @use directives. Un-blocks #63.

@eritbh
Copy link
Member Author

eritbh commented Jan 27, 2021

Sass is run as npx -q sass FILENAME because for some reason Github Actions doesn't allow npm install --global, and without a global install, binaries distributed in npm packages aren't on PATH. The node_modules location in Actions can be weird, so we just run it through npx to avoid confusion. -q suppresses output from npx itself downloading the package in a fresh environment before executing it.

The --no-charset Sass flag makes the CSS filter step of the build process obsolete, but I'm leaving it in for now.

@eritbh eritbh requested a review from durinthal January 27, 2021 02:50
@eritbh eritbh merged commit da8c06e into main Feb 8, 2021
@eritbh eritbh deleted the upgrade-sass branch February 8, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant