Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Base.eltype for QuantumObject #29

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

ytdHuang
Copy link
Member

This helps to directly obtain the element type in QuantumObject.data, e.g., Int64, Float64, ComplexF64 ...
I think this would be quite useful when developing new functionality in the future.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.19%. Comparing base (be2142d) to head (8f4926c).
Report is 3 commits behind head on main.

Files Patch % Lines
src/quantum_object.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   90.23%   90.19%   -0.05%     
==========================================
  Files          16       16              
  Lines        1567     1570       +3     
==========================================
+ Hits         1414     1416       +2     
- Misses        153      154       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang
Copy link
Member Author

I'm didn't write a test for this feature since it's just calling the function in Base.
For the code coverage, it will be automatically covered by the tests for new developed features.

@albertomercurio
Copy link
Member

Yes this is fine. Thank you.

BTW, I'm at RIKEN right now 😄

@albertomercurio albertomercurio merged commit c744b15 into qutip:main Mar 18, 2024
4 of 6 checks passed
@ytdHuang ytdHuang deleted the dev/eltype branch March 18, 2024 11:09
@ytdHuang ytdHuang mentioned this pull request Mar 18, 2024
2 tasks
@ytdHuang
Copy link
Member Author

Yes this is fine. Thank you.

BTW, I'm at RIKEN right now 😄

Nice~ I'll arrive at Sunday afternoon this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants