Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor (for qtils) #20

Merged
merged 5 commits into from
Jan 29, 2024
Merged

refactor (for qtils) #20

merged 5 commits into from
Jan 29, 2024

Conversation

turuslan
Copy link

@turuslan turuslan commented Nov 13, 2023 •
edited
Loading

  • encode/decode to/from existing stream return outcome.
  • simplify testutil/outcome macros.
    • EXPECT_EC means there more error types than just error_code.
  • fix ci clang tidy script.

@turuslan turuslan requested a review from Harrm November 13, 2023 09:27
Harrm
Harrm reviewed Jan 29, 2024
View reviewed changes
include/scale/scale.hpp Show resolved Hide resolved
scripts/build.sh Outdated Show resolved Hide resolved
@turuslan
kagome venv
4d56800 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from Harrm January 29, 2024 09:44
@turuslan turuslan merged commit bd457d4 into master Jan 29, 2024
4 checks passed
@turuslan turuslan deleted the refactor/1 branch January 29, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harrm Harrm Harrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turuslan @Harrm