Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch_xla2] Fix op_info test for scatter_reduce #8058

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

dvhg
Copy link
Contributor

@dvhg dvhg commented Sep 24, 2024

Following up on #8045.

Note: Behavior for reduce='mean' with integer types doesn't seem well defined in torch docs. The current implementation passes tests but could be fragile.

@qihqi qihqi self-requested a review September 24, 2024 21:38
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@ManfeiBai ManfeiBai merged commit 5b6e8cf into pytorch:master Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants