Uncomment tests that are passing. #8035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I unskipped the tests in the skiplist and checked which tests were actually passing.
cornmander
force-pushed
the
false-negatives
branch
from
3e98f2f
to
e57d216
Compare
This was referenced Sep 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I unskipped the tests in the skiplist and checked which tests were actually passing.
I changed the conditional
ops_to_test = [ test for test in op_db if ([test.name](http://test.name/) not in skiplist and test.variant_test_name not in variant_test_name_to_skip) ]to ONLY test the skipped tests and then re-commented the ones that failed.