Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiler annotation for the decoderonly example #8034

Closed
wants to merge 1 commit into from

Conversation

JackCaoG
Copy link
Collaborator

Originally I want to keep this file pure pytorch but many times I use this example to do real debugging and I have to readd annotations every time which is a bit annoying.

Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JackCaoG JackCaoG force-pushed the JackCaoG/add_profile_annotation_for_example branch from b6f351b to 852aa4f Compare September 30, 2024 18:40
@JackCaoG
Copy link
Collaborator Author

Ok I realized I can't do this because profile annotation is not torch.compile friendly and I use this file in a unit test. closing this issue.

@JackCaoG JackCaoG closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants