New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixes for narrow_copy and narrow ops #8021

Merged

ManfeiBai merged 1 commit into pytorch:master from matinehAkhlaghinia:op-fix

Sep 16, 2024

Contributor

matinehAkhlaghinia commented Sep 16, 2024

Adds support for nansum, narrow_copy and narrow. This is a partial fix for #7514.

nansum: the tests passed by default when I removed it.
narrow_copy: the lowering was missing.
narrow: this was decomposed to slice and the slice implementation was not wrapping the negative dimensions correctly. Wrapping the dimension fixed the tests.


          Add fixes for narrow_copy and narrow ops

7635eb1

ManfeiBai approved these changes

View reviewed changes

Collaborator

ManfeiBai left a comment

Thanks, LGTM

ManfeiBai merged commit 008004d into pytorch:master

3 checks passed

ManfeiBai added 2024Q3-manfei-review torchxla2 torchxla2-op labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024Q3-manfei-review torchxla2-op torchxla2