Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type annotation for 3.8 #7701

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix type annotation for 3.8 #7701

merged 2 commits into from
Jul 17, 2024

Conversation

JackCaoG
Copy link
Collaborator

No description provided.

@JackCaoG
Copy link
Collaborator Author

upstream update is green pytorch/pytorch#130896, this one is ready for review.

zpcore
zpcore approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Nit: We can use from typing import OrderedDict to be consistent with other typings.

@JackCaoG
Copy link
Collaborator Author

Thanks for the fix!

Nit: We can use from typing import OrderedDict to be consistent with other typings.

There is a naming conflict I believe, because we also do

from collections import OrderedDict

will-cromar
will-cromar approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@will-cromar will-cromar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JackCaoG JackCaoG merged commit 9952e38 into master Jul 17, 2024
21 of 22 checks passed
@JackCaoG JackCaoG deleted the JackCaoG/fix_more_py38_issue branch July 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qihqi qihqi qihqi approved these changes

@zpcore zpcore zpcore approved these changes

@will-cromar will-cromar will-cromar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackCaoG @qihqi @zpcore @will-cromar