Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update debug_single_process to false #7695

Merged
merged 2 commits into from
Jul 17, 2024
Merged

update debug_single_process to false #7695

merged 2 commits into from
Jul 17, 2024

Conversation

zpcore
Copy link
Collaborator

@zpcore zpcore commented Jul 16, 2024

No description provided.

@zpcore zpcore marked this pull request as ready for review July 16, 2024 21:57
Copy link
Collaborator

@will-cromar will-cromar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test/test_train_mp_imagenet.py Outdated Show resolved Hide resolved
@zpcore zpcore merged commit 44f88a9 into master Jul 17, 2024
23 checks passed
@zpcore zpcore deleted the piz/fix_mp branch July 17, 2024 04:35
@miladm
Copy link
Collaborator

miladm commented Jul 22, 2024

qq: is there a plan to migrate all such API calls? (e.g. https://github.com/pytorch/xla/blob/master/test/test_train_mp_mnist.py#L220) @zpcore

@miladm miladm added the usability Bugs/features related to improving the usability of PyTorch/XLA label Jul 22, 2024
@zpcore
Copy link
Collaborator Author

zpcore commented Jul 22, 2024

qq: is there a plan to migrate all such API calls? (e.g. https://github.com/pytorch/xla/blob/master/test/test_train_mp_mnist.py#L220) @zpcore

Yes, I will make a follow up PR to apply torch_xla.launch() to all tests and update the doc. @will-cromar and @JackCaoG to see if you have any concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Bugs/features related to improving the usability of PyTorch/XLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants