Revert "Remove stack dump for compiler failure which can happen often" (

#7226)
pytorch · Jun 12, 2024 · f4665a7 · f4665a7
1 parent 283abda
commit f4665a7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/torch_xla/csrc/runtime/debug_macros.h b/torch_xla/csrc/runtime/debug_macros.h
@@ -21,10 +21,4 @@ T ConsumeValue(xla::StatusOr<T>&& status) {
   return std::move(status).value();
 }
 
-template <typename T>
-T ConsumeValueNoStackDump(xla::StatusOr<T>&& status) {
-  TF_CHECK_OK(status.status());
-  return std::move(status).value();
-}
-
 #endif  // XLA_CLIENT_DEBUG_MACROS_H_
diff --git a/torch_xla/csrc/runtime/pjrt_computation_client.cc b/torch_xla/csrc/runtime/pjrt_computation_client.cc
@@ -632,8 +632,7 @@ std::vector<ComputationClient::ComputationPtr> PjRtComputationClient::Compile(
       TF_VLOG(3) << "memory usage is not availiable";
     }
 
-    const auto& hlo_modules =
-        ConsumeValueNoStackDump(executable->GetHloModules());
+    const auto& hlo_modules = ConsumeValue(executable->GetHloModules());
     xla::HloComputation* hlo_computation = hlo_modules[0]->entry_computation();
     std::shared_ptr<PjRtComputation> pjrt_computation =
         std::make_shared<PjRtComputation>(