Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix vmap monkey patching #1009

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[BugFix] Fix vmap monkey patching #1009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7549295
Update
vmoens Sep 25, 2024
f2e6dd3
Update
vmoens Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions tensordict/nn/functional_modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,6 @@ def _unwrap_batched(
with _exclude_td_from_pytree():
flat_batched_outputs, output_spec = tree_flatten(batched_outputs)

for out in flat_batched_outputs:
# Change here:
if isinstance(out, torch.Tensor) or is_tensor_collection(out):
continue
raise ValueError(
f"vmap({_get_name(func)}, ...): `{_get_name(func)}` must only return "
f"Tensors, got type {type(out)} as a return."
)

def incompatible_error():
raise ValueError(
f"vmap({_get_name(func)}, ..., out_dims={out_dims})(<inputs>): "
Expand Down
Loading